Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to set no direct map by default on wcow VSMB devices #1030

Merged

Conversation

katiewasnothere
Copy link
Contributor

This PR adds the option for a user to set NoDirectMap as a default option for VSMB mounts without needing to set the UVM to be fully physically backed.

Signed-off-by: Kathryn Baldauf kabaldau@microsoft.com

@katiewasnothere katiewasnothere requested a review from a team as a code owner May 18, 2021 21:34
Signed-off-by: Kathryn Baldauf <kabaldau@microsoft.com>
@katiewasnothere katiewasnothere merged commit 482a0b8 into microsoft:master May 18, 2021
@katiewasnothere katiewasnothere deleted the vsmb_no_direct_map branch May 18, 2021 22:16
@ambarve
Copy link
Contributor

ambarve commented May 18, 2021

A bit late to the party here but, I think we should add a check similar to this one, to not allow template creation and NoDirectMap set to false at the same time. Template creation needs NoDefaultMap set to true and with this change if someone tries to create a template with NoDirectMap annotation set to false it will silently override that to true and continue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants