Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize LCOW uVM bootfiles update #1861

Merged
merged 1 commit into from
Oct 30, 2023

Commits on Oct 24, 2023

  1. Standardize LCOW uVM bootfiles update

    `NewDefaultOptionsLCOW` sets `RootFSFile` and `KernelFile` depending
    on the contents of the (default) `BootFilesPath` directory and
    `KerenelDirect` field.
    However, if `BootFilesPath` is subsequently updated, those fields are
    not updated.
    This can result in inconsistent behavior, where (depending on if the
    default `BootFilesPath` contains `vmlinux` and `rootfs.vhd` files), a
    uVM created with an overridden `BootFilesPath` may either use `initrd`
    (`kernel`) or `vmlinux` (`rootfs.vhd`), respectively.
    
    Add a `UpdateBootFilesPath` function to consistently change the
    `BootFilesPath` and associated options.
    Update annotation handling to use `UpdateBootFilesPath`.
    Security policy is still performed after the update, so settings will be
    re-overridden for the confidential case, or by other annotations, so
    existing (normal) behavior is persisted.
    
    Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com>
    helsaawy committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    95492db View commit details
    Browse the repository at this point in the history