[release/0.9] Update CI #1891
Merged
[release/0.9] Update CI #1891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helsaawy
force-pushed
the
release0.9-ci-update
branch
from
39bb8af
to
73aa303
Compare
helsaawy
force-pushed
the
release0.9-ci-update
branch
2 times, most recently
from
11f7505
to
fe27619
Compare
Incorporate several CI changes from multiple PRs: - microsoft#1632 - microsoft#1752 - microsoft#1755 - microsoft#1799 - microsoft#1820 - microsoft#1836 - microsoft#1853 - microsoft#1854 It is easier to checkout the changes directly rather than cherry-pick commits and undo any changes that affect code not backported to this release. Remove `/usr/local/include` from `Protobuild.toml`, since it does not exist on Windows, and our CI build logic does not rely on it. Update `.gitignore` and `.gitattributes` to match main. Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com>
helsaawy
force-pushed
the
release0.9-ci-update
branch
from
fe27619
to
5f56c12
Compare
CRI integration tests `TestContainerSymlinkVolumes/*` are consistently failing. Skip until a fix is backported from containerd 1.7 to 1.6. Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com> [release/0.9] Skip failing symlink tests Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com>
Many files were last updated with `github.com/gogo/protobuf@v1.2`, hence the `proto.GoGoProtoPackageIsVersion2` assertion in the `*.pb.go` files. Regenerate them using new version (v1.6.2) of `protoc-gen-gogoctrd`. Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com>
Run `go generate` on repo to bring all auto-generated files up to date. Fix bug in `internal\winapi\winapi.go` where `user.go` is referenced but does not exist. Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com>
helsaawy
force-pushed
the
release0.9-ci-update
branch
from
5f56c12
to
2cccb50
Compare
Merged
kiashok
approved these changes
Sep 18, 2023
anmaxvl
approved these changes
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
release/0.9's CI is missing a lot of changes that have been spread out over different PRs.Rather than manually select the relevant commits and cherry-pick them, checkout
.github/workflows/ci.ymlfrom main and update that file.This adds protobuf and
go genchecks, linting (which fails spectacularly across the repo), and containerd integration tests.Changes are broken out into several commits:
protobuildto update protobuf filesgo generateto update auto-generated filesPrior to this, steps 2 and 3 had not been done in some time (or verified by CI on this branch)