Replace OpenCensus with OpenTelemetry #2136
Open
+2,597
−9,153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akerouanton
force-pushed
the
replace-opencensus
branch
from
b6f4026
to
78eeeb7
Compare
|
@microsoft-github-policy-service agree |
The OpenCensus repo has been archived on July 31, 2023 (see [1]), and thus will receive no further updates. OTel offers a bridge to help transition however this means every project using hcsshim need to set up that bridge. At this point, it seems better to transition to OTel instead. This commit fully replaces OpenCensus with OpenTelemetry v1.21. - Package `internal/oc` has been replaced by `internal/otelutil`. - `octtrpc` has been replaced by `otelttrpc`. - `go.opencensus.io/plugin/ocgrpc` has been replaced by `go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc`. - Whenever possible, span attributes are passed directly when the span is created. [1]: https://opentelemetry.io/blog/2023/sunsetting-opencensus/ Signed-off-by: Albin Kerouanton <albinker@gmail.com>
Previous commit made clear that `(*externalProcess).Wait()` was missing a call to `span.End()`. Signed-off-by: Albin Kerouanton <albinker@gmail.com>
akerouanton
force-pushed
the
replace-opencensus
branch
from
78eeeb7
to
136345a
Compare
|
Hi @akerouanton, thanks for sending this PR! Currently we have some internal usage of the OC spans, so I'd like to make sure we have a smooth transition from OC to OTel to ensure nothing breaks. So, my current thinking is we should do something like the following:
With this in place, we'd be able to get OTel support merged, but keep internal usage going to OC until we can validate that the OTel work won't break anything. As a plus, this approach also gives us a way to potentially inject other span-wide instrumentation, such as using Let me know if you have thoughts on this approach. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is almost ready to review but I'd like to see if/where the CI fails before putting it out of draft mode.
The OpenCensus repo has been archived on July 31, 2023 (see here), and thus will receive no further updates. OTel offers a bridge to help transition however this means every project using hcsshim need to set up that bridge. At this point, it seems better to transition to OTel instead.
This commit fully replaces OpenCensus with OpenTelemetry v1.21.
internal/ochas been replaced byinternal/otelutil.octtrpchas been replaced byotelttrpc.go.opencensus.io/plugin/ocgrpchas been replaced bygo.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc.