-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vendor: update docker/docker and docker/cli to v27.0.1, and fix dependency versions #2184
Open
thaJeztah
wants to merge
14
commits into
microsoft:main
Choose a base branch
from
thaJeztah:main_update_deps
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,603
−2,150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to match the version used by docker, which doesn't have a go.mod yet, so go modules won't automatically pick up it's dependencies; https://github.com/moby/moby/blob/v27.0.1/vendor.mod#L40 full diff: docker/go-connections@v0.4.0...v0.5.0 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
to match the version used by docker, which doesn't have a go.mod yet, so go modules won't automatically pick up it's dependencies; https://github.com/moby/moby/blob/v27.0.1/vendor.mod#L39 full diff: distribution/distribution@v2.8.2...v2.8.3 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
to match the version used by docker, which doesn't have a go.mod yet, so go modules won't automatically pick up it's dependencies; https://github.com/moby/moby/blob/v27.0.1/vendor.mod#L148 full diff: containerd/ttrpc@v1.2.4...v1.2.5 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
to match the version used by docker, which doesn't have a go.mod yet, so go modules won't automatically pick up it's dependencies; https://github.com/moby/moby/blob/v27.0.1/vendor.mod#L71 full diff: moby/sys@mountinfo/v0.6.2...mountinfo/v0.7.1 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
to match the version used by docker, which doesn't have a go.mod yet, so go modules won't automatically pick up it's dependencies; https://github.com/moby/moby/blob/v27.0.1/vendor.mod#L103 full diff: golang/mod@v0.14.0...v0.17.0 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
to match the version used by docker, which doesn't have a go.mod yet, so go modules won't automatically pick up it's dependencies; https://github.com/moby/moby/blob/v27.0.1/vendor.mod#L221 full diff: golang/tools@v0.15.0...v0.16.0 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
to match the version used by docker, which doesn't have a go.mod yet, so go modules won't automatically pick up it's dependencies; https://github.com/moby/moby/blob/v27.0.1/vendor.mod#L92 full diff: vbatts/tar-split@v0.11.3...v0.11.5 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
to match the version used by docker, which doesn't have a go.mod yet, so go modules won't automatically pick up it's dependencies; https://github.com/moby/moby/blob/v27.0.1/vendor.mod#L80 full diff: opencontainers/runc@v1.1.12...v1.1.13 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
to match the version used by docker, which doesn't have a go.mod yet, so go modules won't automatically pick up it's dependencies; https://github.com/moby/moby/blob/v27.0.1/vendor.mod#L145 full diff: containerd/go-runc@v1.0.0...v1.1.0 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
to match the version used by docker, which doesn't have a go.mod yet, so go modules won't automatically pick up it's dependencies; https://github.com/moby/moby/blob/v27.0.1/vendor.mod#L59 full diff: klauspost/compress@v1.17.0...v1.17.4 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
to match the version used by docker, which doesn't have a go.mod yet, so go modules won't automatically pick up it's dependencies; https://github.com/moby/moby/blob/v27.0.1/vendor.mod#L29 full diff: containerd/continuity@v0.4.2...v0.4.3 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
to match the version used by docker, which doesn't have a go.mod yet, so go modules won't automatically pick up it's dependencies; https://github.com/moby/moby/blob/v27.0.1/vendor.mod#L147 full diff: containerd/stargz-snapshotter@estargz/v0.14.3...estargz/v0.15.1 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
to match the version used by docker, which doesn't have a go.mod yet, so go modules won't automatically pick up it's dependencies; https://github.com/docker/cli/blob/v27.0.1/vendor.mod#L16 full diff: docker/docker-credential-helpers@v0.7.0...v0.8.2 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
The v27.0.0 release of the module was an incorrectly tagged v27.0.0-rc.1, but because the repository is not a module yet, it couldn't be retracted, so updating it to the latest version manually. Also updating docker/cli accordingly, to prevent compatibility issues. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
cc @kiashok 🙈 could you kick CI on this one as well? (🫶 ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vendor: github.com/docker/go-connections v0.5.0
to match the version used by docker, which doesn't have a go.mod yet,
so go modules won't automatically pick up it's dependencies;
https://github.com/moby/moby/blob/v27.0.1/vendor.mod#L40
full diff: docker/go-connections@v0.4.0...v0.5.0
vendor: github.com/docker/distribution v2.8.3
to match the version used by docker, which doesn't have a go.mod yet,
so go modules won't automatically pick up it's dependencies;
https://github.com/moby/moby/blob/v27.0.1/vendor.mod#L39
full diff: distribution/distribution@v2.8.2...v2.8.3
vendor: github.com/containerd/ttrpc v1.2.5
to match the version used by docker, which doesn't have a go.mod yet,
so go modules won't automatically pick up it's dependencies;
https://github.com/moby/moby/blob/v27.0.1/vendor.mod#L148
full diff: containerd/ttrpc@v1.2.4...v1.2.5
vendor: github.com/moby/sys/mountinfo v0.7.1
to match the version used by docker, which doesn't have a go.mod yet,
so go modules won't automatically pick up it's dependencies;
https://github.com/moby/moby/blob/v27.0.1/vendor.mod#L71
full diff: moby/sys@mountinfo/v0.6.2...mountinfo/v0.7.1
vendor: golang.org/x/mod v0.17.0
to match the version used by docker, which doesn't have a go.mod yet,
so go modules won't automatically pick up it's dependencies;
https://github.com/moby/moby/blob/v27.0.1/vendor.mod#L103
full diff: golang/mod@v0.14.0...v0.17.0
vendor: golang.org/x/tools v0.16.0
to match the version used by docker, which doesn't have a go.mod yet,
so go modules won't automatically pick up it's dependencies;
https://github.com/moby/moby/blob/v27.0.1/vendor.mod#L221
full diff: golang/tools@v0.15.0...v0.16.0
vendor: github.com/vbatts/tar-split v0.11.5
to match the version used by docker, which doesn't have a go.mod yet,
so go modules won't automatically pick up it's dependencies;
https://github.com/moby/moby/blob/v27.0.1/vendor.mod#L92
full diff: vbatts/tar-split@v0.11.3...v0.11.5
vendor: github.com/opencontainers/runc v1.1.13
to match the version used by docker, which doesn't have a go.mod yet,
so go modules won't automatically pick up it's dependencies;
https://github.com/moby/moby/blob/v27.0.1/vendor.mod#L80
full diff: opencontainers/runc@v1.1.12...v1.1.13
vendor: github.com/containerd/go-runc v1.1.0
to match the version used by docker, which doesn't have a go.mod yet,
so go modules won't automatically pick up it's dependencies;
https://github.com/moby/moby/blob/v27.0.1/vendor.mod#L145
full diff: containerd/go-runc@v1.0.0...v1.1.0
vendor: github.com/klauspost/compress v1.17.4
to match the version used by docker, which doesn't have a go.mod yet,
so go modules won't automatically pick up it's dependencies;
https://github.com/moby/moby/blob/v27.0.1/vendor.mod#L59
full diff: klauspost/compress@v1.17.0...v1.17.4
vendor: github.com/containerd/continuity v0.4.3
to match the version used by docker, which doesn't have a go.mod yet,
so go modules won't automatically pick up it's dependencies;
https://github.com/moby/moby/blob/v27.0.1/vendor.mod#L29
full diff: containerd/continuity@v0.4.2...v0.4.3
vendor: github.com/containerd/stargz-snapshotter/estargz v0.15.1
to match the version used by docker, which doesn't have a go.mod yet,
so go modules won't automatically pick up it's dependencies;
https://github.com/moby/moby/blob/v27.0.1/vendor.mod#L147
full diff: containerd/stargz-snapshotter@estargz/v0.14.3...estargz/v0.15.1
vendor: github.com/docker/docker-credential-helpers v0.8.2
to match the version used by docker, which doesn't have a go.mod yet,
so go modules won't automatically pick up it's dependencies;
https://github.com/docker/cli/blob/v27.0.1/vendor.mod#L16
full diff: docker/docker-credential-helpers@v0.7.0...v0.8.2
vendor: update docker/docker and docker/cli to v27.0.1
The v27.0.0 release of the module was an incorrectly tagged v27.0.0-rc.1,
but because the repository is not a module yet, it couldn't be retracted,
so updating it to the latest version manually.
Also updating docker/cli accordingly, to prevent compatibility issues.