-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create UVM honoring NUMA configuration parameters #2198
Conversation
Can we remove any schemas that aren't actively being used in this PR? I'm fine with including some extra fields for some of the leaf node schemas but for larger schemas like |
… is configured on same NUMA node as the device. Expose SLIT configuration to UVM to gather NUMA node distances. Signed-off-by: Apurv Barve <apurvbarve@microsoft.com>
Signed-off-by: Apurv Barve <apurvbarve@microsoft.com>
Signed-off-by: Apurv Barve <apurvbarve@microsoft.com>
Signed-off-by: Apurv Barve <apurvbarve@microsoft.com>
ece0a9e
to
17d76db
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a few comments, similar to what @katiewasnothere already mentioned.
Signed-off-by: Apurv Barve <apurvbarve@microsoft.com>
Signed-off-by: Apurv Barve <apurvbarve@microsoft.com>
Signed-off-by: Apurv Barve <apurvbarve@microsoft.com>
Signed-off-by: Apurv Barve <apurvbarve@microsoft.com>
Signed-off-by: Apurv Barve <apurvbarve@microsoft.com>
Signed-off-by: Apurv Barve <apurvbarve@microsoft.com>
…or better readability Signed-off-by: Apurv Barve <apurvbarve@microsoft.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a few nits
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after Maksim's nits are addressed
Signed-off-by: Apurv Barve <apurvbarve@microsoft.com>
Expose NUMA config to containers. Use HCS device affinity so that UVM is configured on same NUMA node as the device. Expose SLIT configuration to UVM to gather NUMA node distances.
Changes under internal/hcs/schema2 are for using new HCS APIs related to NUMA HCS parameters and its dependencies. These files are auto-generated and could be skipped for a thorough review.
Other changes are business logic and should be reviewed thoroughly.
Some tests around device affinity and Hybrid/Virtual MemoryBackingType are pending. Creating PR to get early feedback.