Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start nvidia-persistenced and nv-fabricmanager daemons in init script #2201

Merged

Conversation

katiewasnothere
Copy link
Contributor

This PR adds the ability to run nvidia-persistenced and nv-fabricmanager in the init script. Does not fail the init script if the binaries for these daemons are not on the system. This PR additionally adds helper functions for writing to dmesg.

This is the first iteration of this support. This work is incomplete without the ability to get insights into the statuses of the daemons and collect their logs. Most daemons write logs using syslog, however, since we do not use systemd, we need an alternative to this in the future.

@katiewasnothere katiewasnothere marked this pull request as ready for review July 17, 2024 00:41
@katiewasnothere katiewasnothere requested a review from a team as a code owner July 17, 2024 00:41
FILE * f_kmsg = fdopen(fd_kmsg, "w");
if (f_kmsg == NULL) {
warn("error getting /dev/kmsg file");
return;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing close(fd_kmsg)

Signed-off-by: Kathryn Baldauf <kabaldau@microsoft.com>
@katiewasnothere katiewasnothere merged commit eb8c5c6 into microsoft:main Jul 23, 2024
19 checks passed
@katiewasnothere katiewasnothere deleted the kabaldau/boot_nvidia_services branch July 23, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants