Filter vendor and test CodeQL results #2243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skip scanning for files under the `test/` or `vendor/` directories, or for `_test.go` files. Neither the Go or C/C++ CodeQL scanning support the `path-ignore` config options, raising the warning: ``` Path filters have no effect for Go Go does not support path-based filtering. The paths and paths-ignore configuration properties will have no effect for this language. ``` Use the recommended `advanced-security/filter-sarif` action to instead filter results, based on [provided example](https://github.com/advanced-security/filter-sarif?tab=readme-ov-file#example). Remove the config file since there is nothing to configure. Additionally, build the `securitypolicy.exe` and `dmverity-vhd` binaries during CodeQL, and `securitypolicy` during the normal build CI. Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com>
kiashok
approved these changes
Aug 22, 2024
katiewasnothere
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skip scanning for files under the
test/orvendor/directories, or for_test.gofiles.Neither the Go or C/C++ CodeQL scanning support the
path-ignoreconfig options, raising the warning:Use the recommended
advanced-security/filter-sarifaction to instead filter results, based on provided example.Remove the config file since there is nothing to configure.
Additionally, build the
securitypolicy.exeanddmverity-vhdbinaries during CodeQL, andsecuritypolicyduring the normal build CI.