-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SQL Health Check] Handle HTTP exceptions #902
[SQL Health Check] Handle HTTP exceptions #902
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there also some way to check if the access is controlled by the customer? Maybe we can pass in a config or something that will have a flag if the SQL connection is customer controlled?
I'm worried about this filtering out health check failures that are caused by actual bugs. For example, in Dicom SQL is completely internal so there's no way a customer could mess anything up. If we get a Forbidden or Unauthorized exception, we would want to throw an exception here because that means something to do with our token is messed up.
SQL Health Check - Handle HTTP exception
Related issues
Testing
Added new unit test to ensure errors in SQL Health Checks are handled properly.