Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Add support to return the job after submitting a run #952

Merged
merged 7 commits into from
Aug 16, 2024

Conversation

samb-t
Copy link
Contributor

@samb-t samb-t commented Aug 15, 2024

Currently when calling submit_to_azure_if_needed with submit_to_azureml=True, python is exited after the job is submitted. This PR adds an option exit_on_completion to control whether this happens. If exit_on_completion is False then the submitted Run/Job objects are returned.

@samb-t samb-t requested review from ant0nsc and fepegar August 15, 2024 10:49
hi-ml-azure/testazure/testazure/test_himl.py Outdated Show resolved Hide resolved
Co-authored-by: Fernando Pérez-García <fepegar@gmail.com>
Copy link
Collaborator

@ant0nsc ant0nsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good - and well done for also mastering the test suite!

hi-ml-azure/src/health_azure/himl.py Outdated Show resolved Hide resolved
hi-ml-azure/src/health_azure/himl.py Outdated Show resolved Hide resolved
hi-ml-azure/src/health_azure/himl.py Outdated Show resolved Hide resolved
samb-t and others added 4 commits August 16, 2024 10:10
Co-authored-by: Anton Schwaighofer <antonsc@microsoft.com>
Co-authored-by: Anton Schwaighofer <antonsc@microsoft.com>
Co-authored-by: Anton Schwaighofer <antonsc@microsoft.com>
Copy link

codecov bot commented Aug 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.66%. Comparing base (f4e21b7) to head (6184bbe).
Report is 6 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (f4e21b7) and HEAD (6184bbe). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (f4e21b7) HEAD (6184bbe)
hi-ml-cpath 2 1
Additional details and impacted files

Impacted file tree graph

Flag Coverage Δ
hi-ml-cpath 48.62% <ø> (-27.61%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
hi-ml-azure/src/health_azure/himl.py 42.80% <ø> (+0.14%) ⬆️

... and 55 files with indirect coverage changes

@samb-t samb-t merged commit c78a707 into main Aug 16, 2024
43 checks passed
@samb-t samb-t deleted the sambt/return-run-after-submitting branch August 16, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants