Add proposal for Vulkan cooperative matrix #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This propsal will expose the [VK_KHR_cooperative_matrix](https://registry.khronos.org/vulkan/specs/1.3-extensions/man/html/VK_KHR_cooperative_matrix.html) extension in HLSL.
s-perron
commented
Jul 4, 2024
s-perron
commented
Jul 4, 2024
Keenuts
reviewed
Jul 29, 2024
jeffbolznv
reviewed
Jul 30, 2024
We add the ability to do loads and stores from groupshared memory. This involved adding a WorkgroupSpirvPointer type that is used by the Load and Store functions. We also create a GetGroupSharedAddress function to get the address. The other load and store function are refactored to make the layout a parameter, to move the memory access mask to a template parameter, and to always have a stride. All memory layouts require an explicit stride, so even though the stride is optional on the instructions, there is not case where it can be ommitted.
jeffbolznv
reviewed
Aug 1, 2024
s-perron
commented
Aug 1, 2024
jeffbolznv
reviewed
Aug 9, 2024
llvm-beanz
approved these changes
Aug 9, 2024
There was a problem hiding this comment.
I'm going to approve this just to be clear that this is fully approved and the direction is awesome.
I know there are some details still being worked out, but the direction of this proposal is fantastic and I'm eager for its inclusion.
Thank you everyone for all the amazing work on this!
|
@jeffbolznv @Keenuts I think I have this done. Let me know if there are any other issues. I'll be on vacation for a week. I'll do any fixups when I return. I hope to merge at that time. I have the implementation done, and ready to be reviewed as soon as this merges. |
jeffbolznv
reviewed
Aug 9, 2024
1. Fixed some typos in the function comments. 2. Change the memoryAccessMask to a uint32_t and renamed to avoid undefined behaviour. 3. Removed the reason for defaulting to coherent memory because we no longer do that.
Keenuts
approved these changes
Aug 21, 2024
Co-authored-by: Nathan Gauër <github@keenuts.net>
llvm-beanz
pushed a commit
to llvm-beanz/hlsl-specs
that referenced
this pull request
Feb 9, 2025
This propsal will expose the [VK_KHR_cooperative_matrix](https://registry.khronos.org/vulkan/specs/1.3-extensions/man/html/VK_KHR_cooperative_matrix.html) extension in HLSL.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This propsal will expose the
VK_KHR_cooperative_matrix
extension in HLSL.