Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added some details based on the runtime implementation of hash bypass. #302

Merged
merged 23 commits into from
Aug 16, 2024
Merged

Added some details based on the runtime implementation of hash bypass. #302

merged 23 commits into from
Aug 16, 2024

Conversation

amarpMSFT
Copy link
Collaborator

  • The debug layer message ID on bytecode validation messages is D3D12_MESSAGE_ID_BYTECODE_VALIDATION_ERROR
  • The app can query the runtime for support for the bypass hash (if the app doesn't know what runtime it's running on)

amarpMSFT and others added 19 commits July 30, 2024 18:42
@amarpMSFT
Flesh out runtime bytecode validation behavior.
71dbd1c
@amarpMSFT
Add comment describing HRESULT return for SetBytecodeFlags
a34b0d4
@amarpMSFT @llvm-beanz
Apply suggestions from code review
399d951 
Co-authored-by: Chris B <cbieneman@microsoft.com>
@amarpMSFT
Adding myself as an author
09a7f5c
@amarpMSFT
Typo and wording cleanup.
2505ac6
@amarpMSFT
Typo
8218ccf
@amarpMSFT
Fixed flag typo
66467bf
@amarpMSFT
Reverse order that runtime loads validator dlls to dxil.dll first the…
f01b564 
…n dxcompiler.dll

Comment from Tex:

For the foreseeable future, I believe the validator will be used to check clang output.  If so, why use the full DXC compiler rather than the lighter-weight DXIL.dll?  Plus, this dll can be used to update container contents (strip/replace/add certain parts) easily.
@amarpMSFT
Added IDxcValidator API update section
c568f03 
Suggested by Tex
@amarpMSFT
Update to runtime validation control flags and validator implementati…
66c671e 
…on search order
@amarpMSFT @tex3d
Simplify new flag proposal (though it looks like it will be cut anyhow)
8e425ce 
Co-authored-by: Tex Riddell <texr@microsoft.com>
@amarpMSFT @tex3d
Flag typo
880b83d 
Co-authored-by: Tex Riddell <texr@microsoft.com>
@amarpMSFT
Moved runtime behavior to new Detailed Design section, per Tex's sugg…
1346430 
…estion
@amarpMSFT
Remove option for runtime to run validator, and removed proposed skip…
2d2f6af 
…Hash flag
@amarpMSFT
Move validator controls to debug layer (was a device method).
b2fba3b
@amarpMSFT @damyanp
Update proposals/infra/INF-0004-validator-hashing.md
d0f4e24 
Co-authored-by: Damyan Pepper <damyanp@microsoft.com>
@amarpMSFT
Clean up enum naming to follow local convention
ea7a8a0
@amarpMSFT
Merge branch 'microsoft:main' into main
e7e9b94
@amarpMSFT
Extra runtime details for bypass hash.
34eb1be
@amarpMSFT amarpMSFT marked this pull request as ready for review August 14, 2024 02:53
coopp
coopp approved these changes Aug 14, 2024
View reviewed changes
Copy link
Collaborator

@coopp coopp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat! I like that this can be queried for support.

damyanp
damyanp approved these changes Aug 15, 2024
View reviewed changes
Copy link
Member

@damyanp damyanp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of suggestions.

proposals/infra/INF-0004-validator-hashing.md Outdated Show resolved Hide resolved
proposals/infra/INF-0004-validator-hashing.md Outdated Show resolved Hide resolved
@amarpMSFT amarpMSFT merged commit dd297b6 into microsoft:main Aug 16, 2024
1 check passed
llvm-beanz pushed a commit to llvm-beanz/hlsl-specs that referenced this pull request Feb 9, 2025
@amarpMSFT @llvm-beanz
Added some details based on the runtime implementation of hash bypass. (
fc8616d 
microsoft#302)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damyanp damyanp damyanp approved these changes

@coopp coopp coopp approved these changes

@llvm-beanz llvm-beanz Awaiting requested review from llvm-beanz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amarpMSFT @damyanp @coopp