Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable gateway support #490

Merged
merged 3 commits into from
Oct 5, 2022
Merged

enable gateway support #490

merged 3 commits into from
Oct 5, 2022

Conversation

xinlian12
Copy link
Contributor

  1. Add gateway support
  2. Add connectionSharing support for direct mode

@xinlian12 xinlian12 requested a review from a team as a code owner October 5, 2022 00:31
FabianMeiswinkel
FabianMeiswinkel previously approved these changes Oct 5, 2022
View reviewed changes
Copy link
Contributor

@FabianMeiswinkel FabianMeiswinkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

FabianMeiswinkel
FabianMeiswinkel approved these changes Oct 5, 2022
View reviewed changes
Copy link
Contributor

@FabianMeiswinkel FabianMeiswinkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xinlian12 xinlian12 merged commit 21e7981 into microsoft:dev Oct 5, 2022
@xinlian12 xinlian12 deleted the enableGatewayMode2 branch October 5, 2022 17:33
@xinlian12 xinlian12 mentioned this pull request Oct 13, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FabianMeiswinkel FabianMeiswinkel FabianMeiswinkel approved these changes

@kushagraThapar kushagraThapar kushagraThapar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xinlian12 @kushagraThapar @FabianMeiswinkel