Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

usingLsnAsTheRecordOffset #534

Merged
merged 7 commits into from
Oct 23, 2023
Merged

usingLsnAsTheRecordOffset #534

merged 7 commits into from
Oct 23, 2023

Conversation

xinlian12
Copy link
Contributor

@xinlian12 xinlian12 commented Oct 17, 2023 •
edited
Loading

Use the lsn from the item to construct the record offset, by doing this, we can remove the unnecessary lease query request

@xinlian12 xinlian12 requested a review from a team as a code owner October 17, 2023 18:34
kushagraThapar
kushagraThapar approved these changes Oct 23, 2023
View reviewed changes
Copy link
Collaborator

@kushagraThapar kushagraThapar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @xinlian12

aayush3011
aayush3011 approved these changes Oct 23, 2023
View reviewed changes
Copy link
Contributor

@aayush3011 aayush3011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@xinlian12 xinlian12 merged commit 0f01263 into microsoft:dev Oct 23, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kushagraThapar kushagraThapar kushagraThapar approved these changes

@aayush3011 aayush3011 aayush3011 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xinlian12 @aayush3011 @kushagraThapar