genpolicy sync with upstream [1/3] #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add metadata containing the Policy annotation if the user didn't provide any metadata in the input yaml file. For a simple sanity test using a Kata CI YAML file: genpolicy -u -y job.yaml kubectl apply -f job.yaml kubectl get pods | grep job job-pi-test-64dxs 0/1 Completed 0 14s Fixes: kata-containers#8891 Signed-off-by: Dan Mihai <dmihai@microsoft.com>
Validating the node name is currently outside the scope of the CoCo policy. This change unblocks testing using Kata CI's test-pod-file-volume.yaml and pv-pod.yaml. Fixes: kata-containers#8888 Signed-off-by: Dan Mihai <dmihai@microsoft.com>
danmihai1
approved these changes
Apr 9, 2024
| @@ -277,7 +277,7 @@ | |||
| ] | |||
| }, | |||
| "kata_config": { | |||
| "confidential_guest": false | |||
| "confidential_guest": true | |||
Redent0r
force-pushed
the
saulparedes/genpolicy_sync_1
branch
from
d2df449 to
152db54
Compare
Allow Kata CI's pod-nested-configmap-secret.yaml to work with genpolicy and current cbl-mariner images: 1. Ignore the optional type field of Secret input YAML files. It's possible that CoCo will need a more sophisticated Policy for Secrets, but this change at least unblocks CI testing for already-existing genpolicy features. Simple sanity testing for these changes: genpolicy -u -y pod-nested-configmap-secret.yaml kubectl apply -f pod-nested-configmap-secret.yaml kubectl get pods | grep config nested-configmap-secret-pod 1/1 Running 0 26s Fixes: kata-containers#8892 Signed-off-by: Dan Mihai <dmihai@microsoft.com>
The auto-generated Policy already allows these volumes to be mounted, regardless if they are: - Present, or - Missing and optional Fixes: kata-containers#8893 Signed-off-by: Dan Mihai <dmihai@microsoft.com>
Redent0r
force-pushed
the
saulparedes/genpolicy_sync_1
branch
from
152db54 to
a3d481f
Compare
6 tasks
Redent0r
added
the
upstream/not-needed
Redent0r
changed the title
|
Good for merge once required checks pass |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge Checklist
upstream-missinglabel (orupstream-not-needed) has been set on the PR.Summary
genpolicy sync with upstream [1/3]
Test Methodology
https://dev.azure.com/mariner-org/mariner/_build/results?buildId=547078&view=ms.vss-test-web.build-test-results-tab [pass]