This repository has been archived by the owner on Jul 9, 2024. It is now read-only.
Fix unwanted scopes collection modification in AzureIdentityAccessTokenProvider #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schuettecarsten
requested review from
baywet,
MIchaelMainer,
zengin and
andrueastman
as code owners
|
I've also added a .ConfigureAwait(false) call and replaced the true/false values in SetTag method calls with pre-initialized, boxed values to prevent boxing and reduce heap usage. |
baywet
suggested changes
Jun 25, 2023
baywet
approved these changes
Jun 25, 2023
There was a problem hiding this comment.
Thanks for making the changes. @andrueastman for final review and merge
andrueastman
approved these changes
Jun 26, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also add missing .ConfigureAwait(false)
Fixes #93