Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

downgrade kiota libraries (and graph SDK) to netstandard2.0 #12

Closed
baywet opened this issue Apr 7, 2022 · 5 comments
Closed

downgrade kiota libraries (and graph SDK) to netstandard2.0 #12

baywet opened this issue Apr 7, 2022 · 5 comments
Assignees

Comments

@baywet
Copy link
Member

baywet commented Apr 7, 2022

The Kiota libraries are currently targeting netstandard2.1, which is not supported by dotnet framework (classic).
This makes for a steep adoption curve for people who have existing projects.
I don't believe we actually need 2.1, I think the history there is that we created the projects with net5.0 at the time, and then downgraded to standard 2.1 when came time to reach public preview.

netstandard2.0 should bring the libs back to compatibility with the framework (classic).

If we're using something specific to 2.1, the alternative would be to multi-target 2.1, and 4.6.2, 4.7.2 and 4.8.

@baywet
Copy link
Member Author

baywet commented Apr 12, 2022

thanks for taking the time to tackle this.
it seems that during this PR microsoftgraph/msgraph-sdk-dotnet-core#408 we forgot to rev down the standard version. Would you mind pushing another preview for this one so we can roll it all the way to the service lib please?

@andrueastman
Copy link
Member

Hey @baywet.
I still have some work to do for the core lib hence microsoftgraph/msgraph-sdk-dotnet-core#408 didn't do the drop.
I'll hopefully close this today then we can close this issue.

@baywet
Copy link
Member Author

baywet commented Apr 14, 2022

Thanks! Closing as those were merged too!

@baywet baywet closed this as completed Apr 14, 2022
Repository owner moved this from In Progress to Done in Kiota Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

2 participants