Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop odataQueryHandler #408

Merged
merged 3 commits into from
Apr 12, 2022
Merged

Drop odataQueryHandler #408

merged 3 commits into from
Apr 12, 2022
+40 −212

Conversation

andrueastman
Copy link
Member

@andrueastman andrueastman commented Apr 12, 2022 •
edited by ghost
Loading

This PR closes #406

It drops the ODataQueryParametersHandler in favour of the ParametersNameDecodingHandler available from Kiota core.

Tests have also been refactored for this changes.

Microsoft Reviewers: Open in CodeFlow

@andrueastman andrueastman self-assigned this Apr 12, 2022
@andrueastman andrueastman linked an issue Apr 12, 2022 that may be closed by this pull request
Remove the ODataQueryParametersHandler #406
Closed
@andrueastman andrueastman added this to the Kiota milestone Apr 12, 2022
@andrueastman andrueastman added the Kiota Is solved by Kiota or will be addressed in Kiota label Apr 12, 2022
@andrueastman andrueastman marked this pull request as ready for review April 12, 2022 12:03
@andrueastman andrueastman requested a review from baywet April 12, 2022 12:03
@andrueastman andrueastman enabled auto-merge April 12, 2022 12:03
baywet
baywet requested changes Apr 12, 2022
View reviewed changes
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesn't the csproj need to be updated as well with the new references?

src/Microsoft.Graph.Core/Requests/GraphClientFactory.cs Outdated Show resolved Hide resolved
@andrueastman
Copy link
Member Author

Thanks @baywet

@andrueastman andrueastman merged commit 7402730 into feature/3.0 Apr 12, 2022
@andrueastman andrueastman deleted the dropOdataHandler branch April 12, 2022 14:21
@andrueastman andrueastman mentioned this pull request Apr 12, 2022
Closed
@baywet baywet mentioned this pull request Apr 12, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baywet baywet baywet approved these changes

@MIchaelMainer MIchaelMainer Awaiting requested review from MIchaelMainer

@peombwa peombwa Awaiting requested review from peombwa

@zengin zengin Awaiting requested review from zengin

Assignees

@andrueastman andrueastman

Labels
Kiota Is solved by Kiota or will be addressed in Kiota
Projects
None yet
Milestone
V3
Development

Successfully merging this pull request may close these issues.

Remove the ODataQueryParametersHandler
2 participants
@andrueastman @baywet