Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: issue 128 - Added sanitization for guid #130

Merged
merged 4 commits into from
Sep 25, 2023

Conversation

timandella
Copy link
Contributor

@timandella timandella commented Sep 23, 2023

Added sanitization for guid to fix issue 128
Fixes #128

baywet
baywet previously requested changes Sep 23, 2023
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution. Can you add an entry in the changelog as well please?

@timandella
Copy link
Contributor Author

Added a change log

@github-actions
Copy link
Contributor

This pull request has conflicting changes, the author must resolve the conflicts before this pull request can be merged.

@timandella
Copy link
Contributor Author

Merge conflict resolved

Copy link
Member

@andrueastman andrueastman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @timandella

@andrueastman andrueastman dismissed baywet’s stale review September 25, 2023 06:02

Changes addressed

@andrueastman andrueastman merged commit cd20a6a into microsoft:main Sep 25, 2023
7 checks passed
@timandella timandella deleted the timanndella/issue128 branch September 27, 2023 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Attempting to get URI in RequestInformation, results in an error when one of the query parameters is a Guid
3 participants