Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move abstractions pipelines to 1ES compliant templates #204

Merged
merged 6 commits into from
Mar 26, 2024
Merged

Move abstractions pipelines to 1ES compliant templates #204

merged 6 commits into from
Mar 26, 2024

Conversation

samwelkanda
Copy link
Contributor

Resolves microsoftgraph/msgraph-sdk-dotnet#2355 for Abstractions library

baywet
baywet requested changes Mar 6, 2024
View reviewed changes
.azure-pipelines/ci-build.yml Show resolved Hide resolved
.azure-pipelines/ci-build.yml Show resolved Hide resolved
@samwelkanda samwelkanda requested a review from baywet March 6, 2024 13:33
baywet
baywet previously approved these changes Mar 6, 2024
View reviewed changes
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming we have a test run that works, LGTM. Thanks for taking this!

@samwelkanda
Copy link
Contributor Author

Pipeline run: https://microsoftgraph.visualstudio.com/Graph%20Developer%20Experiences/_build/results?buildId=138533&view=results

baywet
baywet previously approved these changes Mar 8, 2024
View reviewed changes
@samwelkanda samwelkanda marked this pull request as ready for review March 8, 2024 15:56
@samwelkanda samwelkanda requested a review from a team as a code owner March 26, 2024 13:13
baywet
baywet previously approved these changes Mar 26, 2024
View reviewed changes
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@andrueastman andrueastman merged commit bdc1f91 into main Mar 26, 2024
11 checks passed
@andrueastman andrueastman deleted the chore/1ES-pipelines-compliance branch March 26, 2024 13:31
@baywet baywet mentioned this pull request Apr 25, 2024
Closed
@andrueastman andrueastman mentioned this pull request Aug 27, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrueastman andrueastman andrueastman left review comments

@MIchaelMainer MIchaelMainer MIchaelMainer approved these changes

@baywet baywet baywet approved these changes

@ddyett ddyett Awaiting requested review from ddyett

@zengin zengin Awaiting requested review from zengin

Assignees
No one assigned
Labels
None yet
Projects
Kiota
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pipelines compliance
4 participants
@samwelkanda @andrueastman @baywet @MIchaelMainer