Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds reponseheaders to API excpetion #299

Merged
merged 7 commits into from
Apr 27, 2023
Merged

Adds reponseheaders to API excpetion #299

merged 7 commits into from
Apr 27, 2023

Conversation

andrueastman
Copy link
Member

@sonarqubecloud
Copy link

Please retry analysis of this Pull-Request directly on SonarCloud.

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug B 14 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell E 57 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug B 14 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell E 59 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@sonarqubecloud
Copy link

Please retry analysis of this Pull-Request directly on SonarCloud.

@andrueastman andrueastman marked this pull request as ready for review April 26, 2023 07:34
@andrueastman andrueastman enabled auto-merge April 26, 2023 07:34
@andrueastman andrueastman requested a review from baywet April 26, 2023 07:34
@andrueastman andrueastman dismissed baywet’s stale review April 26, 2023 07:34

Case Insensitivity addressed

baywet
baywet previously approved these changes Apr 26, 2023
View reviewed changes
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes!

@andrueastman andrueastman requested a review from baywet April 26, 2023 16:29
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug B 14 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell E 59 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@sonarqubecloud
Copy link

Please retry analysis of this Pull-Request directly on SonarCloud.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@andrueastman andrueastman requested a review from baywet April 27, 2023 06:08
@andrueastman andrueastman merged commit 4a437d1 into main Apr 27, 2023
@andrueastman andrueastman deleted the andrueastman/ResponseHeaders branch April 27, 2023 10:57
This was referenced Apr 27, 2023
Closed
Closed
Open
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baywet baywet baywet approved these changes

@MIchaelMainer MIchaelMainer Awaiting requested review from MIchaelMainer

@zengin zengin Awaiting requested review from zengin

@ramsessanchez ramsessanchez Awaiting requested review from ramsessanchez

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrueastman @baywet