Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Period and Duration aggregate type #487

Merged
merged 8 commits into from
Jul 19, 2023
Merged

Period and Duration aggregate type #487

merged 8 commits into from
Jul 19, 2023

Conversation

andrueastman
Copy link
Member

@andrueastman andrueastman commented Jul 18, 2023 •
edited
Loading

Part of microsoft/kiota#2069

TODO

  • Add more tests for new type
  • Version and release notes

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@microsoft microsoft deleted a comment from sonarqubecloud bot Jul 18, 2023
@microsoft microsoft deleted a comment from sonarqubecloud bot Jul 18, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@andrueastman andrueastman mentioned this pull request Jul 18, 2023
Merged
@microsoft microsoft deleted a comment from sonarqubecloud bot Jul 18, 2023
baywet
baywet approved these changes Jul 18, 2023
View reviewed changes
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! thanks for fixing the docs comments in multiple places

@andrueastman andrueastman marked this pull request as ready for review July 19, 2023 06:34
@andrueastman
Copy link
Member Author

Thanks @baywet

@andrueastman andrueastman merged commit b2d5b84 into main Jul 19, 2023
@andrueastman andrueastman deleted the andrueastman/DateAndPeriod branch July 19, 2023 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baywet baywet baywet approved these changes

@MIchaelMainer MIchaelMainer Awaiting requested review from MIchaelMainer

@zengin zengin Awaiting requested review from zengin

@ramsessanchez ramsessanchez Awaiting requested review from ramsessanchez

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrueastman @baywet