Reflection free query parameters expansion #991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreaTP
requested review from
baywet,
MIchaelMainer,
zengin,
ramsessanchez and
andrueastman
as code owners
baywet
requested changes
Jan 9, 2024
components/abstractions/src/test/java/com/microsoft/kiota/RequestInformationTest.java
Outdated
Show resolved
Hide resolved
components/abstractions/src/main/java/com/microsoft/kiota/RequestInformation.java
Outdated
Show resolved
Hide resolved
…estInformationTest.java Co-authored-by: Vincent Biret <vibiret@microsoft.com>
baywet
approved these changes
Jan 9, 2024
andreaTP
commented
Jan 9, 2024
| name = annotationName; | ||
| } | ||
| } | ||
| public void addQueryParameters(@Nullable final QueryParameters parameters) { |
There was a problem hiding this comment.
argh, forgot a line here:
if (parameters == null) return;
There was a problem hiding this comment.
arg, I missed it too... Please submit a patch (with patch bump for the version) as I just finished releasing it.
There was a problem hiding this comment.
noticed, and it's ready 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for: microsoft/kiota#3965