Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprication warning being reported on import #250

Merged
merged 5 commits into from
Mar 26, 2024

Conversation

jzyworonek
Copy link
Contributor

Overview

DeprecationWarning was being reported on import.

ImportError while loading conftest '/app/tests/conftest.py'.
tests/conftest.py:11: in <module>
    from src.core.fastapi import get_application, get_router
src/core/fastapi.py:9: in <module>
    from msgraph import GraphServiceClient
/usr/local/lib/python3.12/site-packages/msgraph/__init__.py:5: in <module>
    from .graph_request_adapter import GraphRequestAdapter
/usr/local/lib/python3.12/site-packages/msgraph/graph_request_adapter.py:3: in <module>
    from kiota_abstractions.authentication import AuthenticationProvider
/usr/local/lib/python3.12/site-packages/kiota_abstractions/authentication/__init__.py:3: in <module>
    from .anonymous_authentication_provider import AnonymousAuthenticationProvider
/usr/local/lib/python3.12/site-packages/kiota_abstractions/authentication/anonymous_authentication_provider.py:9: in <module>
    from ..request_information import RequestInformation
/usr/local/lib/python3.12/site-packages/kiota_abstractions/request_information.py:20: in <module>
    from .base_request_configuration import RequestConfiguration
/usr/local/lib/python3.12/site-packages/kiota_abstractions/base_request_configuration.py:30: in <module>
    class BaseRequestConfiguration(RequestConfiguration):
/usr/local/lib/python3.12/site-packages/kiota_abstractions/base_request_configuration.py:31: in BaseRequestConfiguration
    warn(
E   DeprecationWarning: BaseRequestConfiguration is deprecated. Use RequestConfiguration class instead.

Related Issue

Fixes # (issue)

Demo

Simplest reproduction

python -Wd -c "from kiota_abstractions.base_request_configuration import RequestConfiguration"
/Users/jacobzyworonek/Repo/kiota-abstractions-python/kiota_abstractions/base_request_configuration.py:31: DeprecationWarning: BaseRequestConfiguration is deprecated. Use RequestConfiguration class instead.
  warn(

Notes

Optional. Ancillary topics, caveats, alternative strategies that didn't work out, anything else.

Testing Instructions

  • How to test this PR
  • Prefer bulleted description
  • Start after checking out this branch
  • Include any setup required, such as bundling scripts, restarting services, etc.
  • Include test case, and expected output

@jzyworonek
Copy link
Contributor Author

@microsoft-github-policy-service agree

Copy link
Member

@andrueastman andrueastman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @jzyworonek

Any chance you can

@jzyworonek jzyworonek requested a review from andrueastman March 25, 2024 07:18
@andrueastman
Copy link
Member

Update the changelog.md file at the root repository as well as bump the minor version as well

Apologies @jzyworonek . I should have said patch version here. Otherwise looks good to me.

cc @samwelkanda for final review and merge/release.

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@baywet
Copy link
Member

baywet commented Mar 25, 2024

@andrueastman Since Samwel has been re-affected, I don't think we should expect much from him moving forward. Please go ahead with merge/release.

@andrueastman andrueastman merged commit 3a890b7 into microsoft:main Mar 26, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants