Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds path/query parameter sanization #278

Merged
merged 7 commits into from
May 22, 2024
Merged

Conversation

andrueastman
Copy link
Member

Fixes #245

Sanitizes types passed to the path/query object dictionaries to ensure success of various object types in the parameters.
Adds tests to validate date,time,datetime,boolean,number and uuid types.

@andrueastman andrueastman marked this pull request as ready for review May 21, 2024 12:09
@andrueastman andrueastman requested a review from a team as a code owner May 21, 2024 12:09
@andrueastman andrueastman enabled auto-merge May 21, 2024 12:09
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the version in the toml file at the root also needs to be updated

@andrueastman
Copy link
Member Author

Can't seem to spot a version in the toml. Is this the right file? https://github.com/microsoft/kiota-abstractions-python/blob/main/pyproject.toml

@andrueastman andrueastman requested a review from baywet May 21, 2024 13:41
@baywet
Copy link
Member

baywet commented May 21, 2024

interesting, it's not configured like the service lib

I believe it's because of a combination of this file and that directive but maybe @samwelkanda can confirm?
If so, it'd be interesting to replicate in other python repos, for consistency and efficiency.

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@samwelkanda
Copy link
Contributor

@baywet @andrueastman We do not need to update the pyproject.toml file for now as the core libraries use flit to publish packages to PyPI which only requires the VERSION variable to be updated. I agree that we should update the workflows to align with the setup in service libraries that use Python’s built-in build tool. @shemogumbe are you able to take this up?

@baywet
Copy link
Member

baywet commented May 22, 2024

Thanks for the additional context @samwelkanda Before anybody takes anything, I'll go ahead and create issues. So we can schedule things as part of our regular workflow.

@pjmagee
Copy link

pjmagee commented May 22, 2024

Awesome stuff

@shemogumbe
Copy link

Do we go with python build? and align with service libraries?

@andrueastman
Copy link
Member Author

Any chance you can clarify what you mean @shemogumbe?

Do we go with python build? and align with service libraries?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Guid uri template path/query parameter values should be normalized to string
6 participants