Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure all packages are released together. #381

Merged
merged 2 commits into from
Oct 16, 2024
Merged

Conversation

andrueastman
Copy link
Member

Looks like according to googleapis/release-please#1749 for the linked-versions plugin to align the versions, the component will need to be included in the tag.

This will change the tag format in the repo from v1.2.0 to be microsoft-kiota-abstractions-v1.2.0 (therefore publishing a tag for each library similar to kiota-typescript)

@andrueastman andrueastman requested a review from a team as a code owner October 16, 2024 11:44
Copy link

@andrueastman andrueastman merged commit 264bd83 into main Oct 16, 2024
46 checks passed
@andrueastman andrueastman deleted the fixReleasePlease branch October 16, 2024 11:51
@baywet
Copy link
Member

baywet commented Oct 16, 2024

@andrueastman the v prefix is missing now/ this filter needs to be updated

if: startsWith(github.ref, 'refs/tags/v')

@andrueastman
Copy link
Member Author

Thanks for catching that. #383 should allow us to validate if everything will work well including future version bumps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants