correctly serialize None in a list #386
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
We currently have two issues:
None
inside lists.None
to'null'
when there is no key. Simply fixing issue 1 would result in['null', 'null']
instead of[null, null]
.The first issue arises when fetching, for example, all graph site pages of a site and attempting to serialize them. A specific case involves expanding
canvasLayout
and receiving a page without acanvasLayout
, which results inpinnedItems
containing[None, None, None]
.Although whether this response is correct is another question, the serialization should not raise an exception in this scenario but should handle it appropriately.
Testing Instructions
I have added relevant tests. Simply run
pytest
to verify the fix. Running the same tests without my changes will result in an exception.