updates for error mapping #498
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
40 tasks
andrueastman
reviewed
Feb 4, 2022
| using System.IO; | ||
| using System.Linq; | ||
| namespace Graphdotnetv4.Models.Odata.Error { | ||
| public class Error : Exception, IParsable { |
There was a problem hiding this comment.
It feels like this class should be called something like ErrorResponse. Then Error_prop type be called Error instead of "Main".
There was a problem hiding this comment.
This comes from the open api description and can be fixed in there
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
baywet
force-pushed
the
feature/error-description
branch
from
9c4d6ca to
679ba71
Compare
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE, THE OPEN API DESCRIPTIONS NEED TO BE UPATED FIRST