Skip to content
This repository has been archived by the owner on Oct 14, 2024. It is now read-only.

remove null checks for key/value in write_object_value #43

Merged
merged 5 commits into from
Aug 21, 2024

Conversation

shemogumbe
Copy link
Contributor

Fixes #14

Overview

Brief description of what this PR does, and why it is needed.

Related Issue

Fixes # (issue)

Demo

Optional. Screenshots, curl examples, etc.

Notes

Optional. Ancillary topics, caveats, alternative strategies that didn't work out, anything else.

Testing Instructions

  • How to test this PR
  • Prefer bulleted description
  • Start after checking out this branch
  • Include any setup required, such as bundling scripts, restarting services, etc.
  • Include test case, and expected output

@shemogumbe shemogumbe requested a review from a team as a code owner August 19, 2024 16:00
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for starting this, a couple of comments.

shemogumbe and others added 2 commits August 19, 2024 19:30
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making the changes!
I think we'll need a version bump in the toml and a changelog entry and we should be good to go here.

@shemogumbe
Copy link
Contributor Author

Thank you for making the changes! I think we'll need a version bump in the toml and a changelog entry and we should be good to go here.

Looks like version is dynamic, so no need to change it in toml, done so in the version.py file

@shemogumbe shemogumbe merged commit 5c3db6e into main Aug 21, 2024
10 checks passed
@shemogumbe shemogumbe deleted the shem/fix_form_serialization_content_writing_error branch August 21, 2024 17:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FormSerializationWriter does not actually write content to the request
2 participants