Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove json assumption from the request info and make the set content method generic #136

Closed
baywet opened this issue Apr 22, 2021 · 0 comments · Fixed by #170
Closed

remove json assumption from the request info and make the set content method generic #136

baywet opened this issue Apr 22, 2021 · 0 comments · Fixed by #170
Assignees
@baywet
Labels
Csharp Pull requests that update .net code enhancement New feature or request fixed Java TypeScript Pull requests that update Javascript code
Milestone
Alpha

Comments

@baywet
Copy link
Member

baywet commented Apr 22, 2021 •
edited by azure-boards bot
Loading

kiota/abstractions/dotnet/src/RequestInfo.cs

Line 22 in b8c8c87

public void SetJsonContentFromParsable<T>(T item, ISerializationWriterFactory writerFactory) where T : class, IParsable<T>, new() {

Should take the content type as a parameter instead which would be set at code gen from the information obtained in the description.
AB#9129
@baywet baywet added the enhancement New feature or request label Apr 22, 2021
@baywet baywet added this to the Preview milestone Apr 22, 2021
@baywet baywet self-assigned this Apr 22, 2021
@baywet baywet modified the milestones: Preview, Alpha May 2, 2021
@baywet baywet added Csharp Pull requests that update .net code TypeScript Pull requests that update Javascript code Java labels May 20, 2021
@baywet baywet mentioned this issue May 21, 2021
Merged
@baywet baywet linked a pull request May 21, 2021 that will close this issue
removes json assumption for request body #170
Merged
@baywet baywet added the fixed label May 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@baywet baywet

Labels
Csharp Pull requests that update .net code enhancement New feature or request fixed Java TypeScript Pull requests that update Javascript code
Projects
None yet
Milestone
Alpha
Development

Successfully merging a pull request may close this issue.

removes json assumption for request body microsoft/kiota
1 participant
@baywet