Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removes json assumption for request body #170

Merged
merged 13 commits into from
May 26, 2021
Merged

removes json assumption for request body #170

merged 13 commits into from
May 26, 2021

Conversation

baywet
Copy link
Member

@baywet baywet commented May 21, 2021

  • updates generation to remove the json assumption from request body
  • updates abstration library to remove the json assumption
  • updates changelog
  • updates samples reference
  • fixes a bu g where dotnet abstractions would not build because of missing keyword
  • fixes a bug where collections of primitive values would not have the proper type
  • updates samples reference
  • fixes a bug where a comma would be missing in java gen
  • fixes a bug in java gen where importing the same symbol as the current class would make result fail
  • updates sample reference

fixes #136

Generation diff

microsoft/kiota-samples#19

@baywet baywet added this to the Alpha milestone May 21, 2021
@baywet baywet self-assigned this May 21, 2021
@baywet baywet linked an issue May 21, 2021 that may be closed by this pull request
remove json assumption from the request info and make the set content method generic #136
Closed
Base automatically changed from feature/expand-coverage to main May 25, 2021 18:53
@baywet baywet enabled auto-merge May 25, 2021 18:58
baywet added 13 commits May 25, 2021 15:06
@baywet
- updates generation to remove the json assumption from request body
22c73e0
@baywet
- updates abstration library to remove the json assumption
5a0cf5f
@baywet
- updates changelog
93257ad
@baywet
- fixes a bu g where dotnet abstractions would not build because of m…
9dfa337 
…issing keyword
@baywet
- fixes a bug where collections of primitive values would not have th…
61e8528 
…e proper type
@baywet
- fixes a bug where a comma would be missing in java gen
94e04b1
@baywet
- fixes a bug in java gen where importing the same symbol as the curr…
df72ecd 
…ent class would make result fail
@baywet
- bumps patch version for abstraction
daea751
@baywet
- removes outdated comments
e5b227d
@baywet
- adds missing unit tests
0835e9d
@baywet
- removes leaked token from repo (has been revoked)
98d7a7f
@baywet
- adds missing defensive programming on enum writers
c4bf183
@baywet
- adds request body to todo api to increase integration coverage
91ee106
@baywet baywet force-pushed the feature/json-assumption branch from cadf41a to 91ee106 Compare May 25, 2021 19:07
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

95.2% 95.2% Coverage
0.0% 0.0% Duplication

@baywet baywet merged commit fe82f34 into main May 26, 2021
@baywet baywet deleted the feature/json-assumption branch May 26, 2021 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zengin zengin zengin approved these changes

@darrelmiller darrelmiller Awaiting requested review from darrelmiller

@ddyett ddyett Awaiting requested review from ddyett

@MIchaelMainer MIchaelMainer Awaiting requested review from MIchaelMainer

@nikithauc nikithauc Awaiting requested review from nikithauc

@peombwa peombwa Awaiting requested review from peombwa

Assignees

@baywet baywet

Labels
None yet
Projects
None yet
Milestone
Alpha
Development

Successfully merging this pull request may close these issues.

remove json assumption from the request info and make the set content method generic
2 participants
@baywet @zengin