C# - Wrong type for position parameter in RequestBuilder

[Spaeda]

Hello,

When I generate a C# client with Kiota CLI version 1.8.2, result code doesn't correctly detect parameter type in url.
Type is correctly detected only if parameter is last url part (ex. http://myurl/<id>).

My swagger definition:

{
  "openapi": "3.0.1",
  "info": {
    "title": "Api",
    "version": "1.0"
  },
  "paths": {
    "/groups/{groupId}/users": {
      "get": {
        "tags": [
          "PersonEndpoint"
        ],
        "parameters": [
          {
            "name": "groupId",
            "in": "path",
            "required": true,
            "style": "simple",
            "schema": {
              "type": "string",
              "format": "uuid"
            }
          }
        ],
        "responses": {
          "200": {
            "description": "Success"
          }
        }
      }
    },
    "/users/{userId}": {
      "get": {
        "tags": [
          "UserEndpoint"
        ],
        "parameters": [
          {
            "name": "userId",
            "in": "path",
            "required": true,
            "style": "simple",
            "schema": {
              "type": "string",
              "format": "uuid"
            }
          }
        ],
        "responses": {
          "200": {
            "description": "Success"
          }
        }
      }
    }
  },
  "components": { }
}

Used command line: kiota generate -l CSharp -c MyClient -n MyNamespace -d swagger.json -o MyClient

Generated RequestBuilder for my endpoint with parameter as last url part:

// <auto-generated/>
using Microsoft.Kiota.Abstractions;
using MyNamespace.Users.Item;
using System.Collections.Generic;
using System.IO;
using System.Linq;
using System.Threading.Tasks;
using System;
namespace MyNamespace.Users {
    /// <summary>
    /// Builds and executes requests for operations under \users
    /// </summary>
    public class UsersRequestBuilder : BaseRequestBuilder {
        /// <summary>Gets an item from the MyNamespace.users.item collection</summary>
        /// <param name="position">Unique identifier of the item</param>
        public WithUserItemRequestBuilder this[Guid position] { get {
            var urlTplParams = new Dictionary<string, object>(PathParameters);
            urlTplParams.Add("userId", position);
            return new WithUserItemRequestBuilder(urlTplParams, RequestAdapter);
        } }
        /// <summary>Gets an item from the MyNamespace.users.item collection</summary>
        /// <param name="position">Unique identifier of the item</param>
        [Obsolete("This indexer is deprecated and will be removed in the next major version. Use the one with the typed parameter instead.")]
        public WithUserItemRequestBuilder this[string position] { get {
            var urlTplParams = new Dictionary<string, object>(PathParameters);
            if (!string.IsNullOrWhiteSpace(position)) urlTplParams.Add("userId", position);
            return new WithUserItemRequestBuilder(urlTplParams, RequestAdapter);
        } }
        /// <summary>
        /// Instantiates a new UsersRequestBuilder and sets the default values.
        /// </summary>
        /// <param name="pathParameters">Path parameters for the request</param>
        /// <param name="requestAdapter">The request adapter to use to execute the requests.</param>
        public UsersRequestBuilder(Dictionary<string, object> pathParameters, IRequestAdapter requestAdapter) : base(requestAdapter, "{+baseurl}/users", pathParameters) {
        }
        /// <summary>
        /// Instantiates a new UsersRequestBuilder and sets the default values.
        /// </summary>
        /// <param name="rawUrl">The raw URL to use for the request builder.</param>
        /// <param name="requestAdapter">The request adapter to use to execute the requests.</param>
        public UsersRequestBuilder(string rawUrl, IRequestAdapter requestAdapter) : base(requestAdapter, "{+baseurl}/users", rawUrl) {
        }
    }
}

Generated RequestBuilder for my endpoint with the parameter between two url part:

// <auto-generated/>
using Microsoft.Kiota.Abstractions;
using MyNamespace.Groups.Item;
using System.Collections.Generic;
using System.IO;
using System.Linq;
using System.Threading.Tasks;
using System;
namespace MyNamespace.Groups {
    /// <summary>
    /// Builds and executes requests for operations under \groups
    /// </summary>
    public class GroupsRequestBuilder : BaseRequestBuilder {
        /// <summary>Gets an item from the MyNamespace.groups.item collection</summary>
        /// <param name="position">Unique identifier of the item</param>
        public WithGroupItemRequestBuilder this[string position] { get {
            var urlTplParams = new Dictionary<string, object>(PathParameters);
            urlTplParams.Add("groupId", position);
            return new WithGroupItemRequestBuilder(urlTplParams, RequestAdapter);
        } }
        /// <summary>
        /// Instantiates a new GroupsRequestBuilder and sets the default values.
        /// </summary>
        /// <param name="pathParameters">Path parameters for the request</param>
        /// <param name="requestAdapter">The request adapter to use to execute the requests.</param>
        public GroupsRequestBuilder(Dictionary<string, object> pathParameters, IRequestAdapter requestAdapter) : base(requestAdapter, "{+baseurl}/groups", pathParameters) {
        }
        /// <summary>
        /// Instantiates a new GroupsRequestBuilder and sets the default values.
        /// </summary>
        /// <param name="rawUrl">The raw URL to use for the request builder.</param>
        /// <param name="requestAdapter">The request adapter to use to execute the requests.</param>
        public GroupsRequestBuilder(string rawUrl, IRequestAdapter requestAdapter) : base(requestAdapter, "{+baseurl}/groups", rawUrl) {
        }
    }
}

I search in issues but I didn't find any tickets for this bug.

[sebastienlevert]

Just to confirm the bug you are seeing. You mean that the public WithGroupItemRequestBuilder this[string position] should have a corresponding public WithGroupItemRequestBuilder this[Guid position] , the same way the user has it?

[baywet]

Ah, un ancien SUPINFO!! :D
Hi @Spaeda,
Thanks for your interest in kiota and for reaching out.
This is most likely caused by the skip in this method.

kiota/src/Kiota.Builder/KiotaBuilder.cs

Line 1082 in f84da5a

.Skip(parentNode.Path.Count(static x => x == OpenAPIUrlTreeNodePathSeparator)))

The code should probably be updated not to skip anything instead, and use the last parameter in the path segments.

You can add a unit test after this one.

kiota/tests/Kiota.Builder.Tests/KiotaBuilderTests.cs

Line 6138 in f84da5a

public async Task IndexerTypeIsAccurateAndBackwardCompatibleIndexersAreAdded()

With all that information in mind, would you be willing to submit a pull request?