Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get Parameter's PathItems from first child if doesn't exist #3801

Merged
merged 11 commits into from
Dec 7, 2023
Merged

Get Parameter's PathItems from first child if doesn't exist #3801

merged 11 commits into from
Dec 7, 2023

Conversation

Spaeda
Copy link
Contributor

@Spaeda Spaeda commented Nov 27, 2023 •
edited by baywet
Loading

Fixes #3791
When Path Parameter is between 2 segments, PathItems not set in Parameter node but next segment node.

@Spaeda Spaeda requested a review from a team as a code owner November 27, 2023 08:16
@Spaeda
Copy link
Contributor Author

Spaeda commented Nov 27, 2023

@microsoft-github-policy-service agree

baywet
baywet requested changes Nov 27, 2023
View reviewed changes
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! A couple of remarks (I'll apply the code changes momentarily).
Could you also add a changelog entry please? (unreleased, changed)

src/Kiota.Builder/KiotaBuilder.cs Outdated Show resolved Hide resolved
src/Kiota.Builder/KiotaBuilder.cs Outdated Show resolved Hide resolved
tests/Kiota.Builder.Tests/KiotaBuilderTests.cs Show resolved Hide resolved
src/Kiota.Builder/KiotaBuilder.cs Outdated Show resolved Hide resolved
src/Kiota.Builder/KiotaBuilder.cs Outdated Show resolved Hide resolved
src/Kiota.Builder/KiotaBuilder.cs Outdated Show resolved Hide resolved
src/Kiota.Builder/KiotaBuilder.cs Outdated Show resolved Hide resolved
@baywet
Copy link
Member

baywet commented Dec 5, 2023

@Spaeda gentle reminder on this one :)

@Spaeda
Copy link
Contributor Author

Spaeda commented Dec 5, 2023

I had not really time to check all your advice.
I will have time to work on it by the end of the week

Kévin Le Douget and others added 2 commits December 7, 2023 15:47
Changelog
5db904b 
Update UT to check with a URL path with multiple depths
Return empty immutable dictionary
@Spaeda
Merge branch 'main' into main
6daa2e0
baywet
baywet approved these changes Dec 7, 2023
View reviewed changes
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes!

@baywet baywet enabled auto-merge December 7, 2023 16:35
@baywet baywet merged commit bdf094f into microsoft:main Dec 7, 2023
171 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baywet baywet baywet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

C# - Wrong type for position parameter in RequestBuilder
2 participants
@Spaeda @baywet