Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C# project targeting netstandard2.0 generates clients with DateOnly data type (.NET 6+) in indexers #5201

Closed
thom0707 opened this issue Aug 21, 2024 Discussed in #5186 · 1 comment
Assignees
Labels
Csharp Pull requests that update .net code help wanted Issue caused by core project dependency modules or library type:bug A broken experience
Milestone

Comments

@thom0707
Copy link
Contributor

Discussed in #5186

Originally posted by thom0707 August 19, 2024

When targeting netstandard2.0, Kiota can generate C# clients with the DateOnly data type which was introduced in .NET 6, resulting in a project that fails to build. This only seems to appear in generated indexers. The incoming data format from the OpenAPI specification must also be "date".

Reproduced here:
kiota-test repo.
Example of DateOnly

@github-project-automation github-project-automation bot moved this to Needs Triage 🔍 in Kiota Aug 21, 2024
@baywet baywet added type:bug A broken experience help wanted Issue caused by core project dependency modules or library Csharp Pull requests that update .net code labels Aug 21, 2024
@baywet baywet moved this from Needs Triage 🔍 to In Progress 🚧 in Kiota Aug 21, 2024
@baywet baywet added this to the Kiota v1.18 milestone Aug 21, 2024
@baywet
Copy link
Member

baywet commented Aug 21, 2024

Thanks for creating the issue after our discussion.
Since you're already offer to put a PR together on the discussion, I went ahead and assigned it to you for the time being.
Let us know if you have any additional comments or questions.

andrueastman added a commit that referenced this issue Aug 23, 2024
fix #5201: C# refiner now fixes data types for indexers.
@github-project-automation github-project-automation bot moved this from In Progress 🚧 to Done ✔️ in Kiota Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Csharp Pull requests that update .net code help wanted Issue caused by core project dependency modules or library type:bug A broken experience
Projects
Archived in project
Development

No branches or pull requests

2 participants