Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP - Compression Handler #1024

Merged
merged 4 commits into from
Jan 19, 2022
Merged

PHP - Compression Handler #1024

merged 4 commits into from
Jan 19, 2022

Conversation

Ndiritu
Copy link
Contributor

@Ndiritu Ndiritu commented Jan 17, 2022

This implementation:

  • allows the customer to provide callbacks to allow support for other algorithms e.g. br which has no built-in PHP implementation or well supported package on Packagist. Using it would require a customer to install a platform dependency alongside their PHP setup
  • provides GZIP and DEFLATE implementations
  • supports GZIP as the default
  • allows chaining of multiple compression algorithms

part of #364, #598

Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for taking a stab at this. Just one minor comment here. Were you able to test it against canary?

http/php/guzzle/src/Middleware/CompressionHandler.php Outdated Show resolved Hide resolved
@baywet baywet added this to the Community Preview milestone Jan 17, 2022
@Ndiritu Ndiritu requested a review from SilasKenneth January 17, 2022 15:23
@Ndiritu
Copy link
Contributor Author

Ndiritu commented Jan 19, 2022

thanks for taking a stab at this. Just one minor comment here. Were you able to test it against canary?

Tested against canary and it works

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@Ndiritu Ndiritu merged commit 2b371d3 into main Jan 19, 2022
@Ndiritu Ndiritu deleted the php/compression-handler branch January 19, 2022 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants