Add CLI commons package #1180
Merged
Add CLI commons package #1180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calebkiage
requested review from
andrueastman,
baywet,
darrelmiller,
ddyett,
MIchaelMainer,
nikithauc,
peombwa,
ramsessanchez and
zengin
as code owners
baywet
requested changes
Feb 9, 2022
There was a problem hiding this comment.
- add a dependabot configuration for this new package
- add a readme in the commons direcotry to explain what that package does
- add a link in the main readme to this new readme
Also, this won't publish until everything is merged to main, we might want to merge in #738 and #1071 shortly after this one gets merged
|
you also need to update this workflow and that one. |
|
Kudos, SonarCloud Quality Gate passed! |
baywet
approved these changes
Feb 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add commons package that will be used in generated code