Bg-dropped-reqbody-#46 #1214
Merged
Bg-dropped-reqbody-#46 #1214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jobala
requested review from
andrueastman,
baywet,
darrelmiller,
zengin,
MIchaelMainer,
ddyett,
peombwa,
nikithauc and
ramsessanchez
as code owners
baywet
requested changes
Feb 15, 2022
| @@ -42,24 +42,6 @@ func TestCompressionHandlerAddsContentEncodingHeader(t *testing.T) { | |||
| assert.Equal(t, contentTypeHeader, "gzip") | |||
| } | |||
|
|
|||
| func TestCompressionHandlerCompressesRequestBody(t *testing.T) { | |||
There was a problem hiding this comment.
can you expand on why you decided to remove that test please?
There was a problem hiding this comment.
It is not always true that the compressed body will be smaller than the uncompressed body for small payloads.
There was a problem hiding this comment.
thanks for the precision here. We should still check the compression is actually performing compression work in case somebody breaks it in the future. hardcoding the expected size of the result would be ok for that purpose I think.
|
Kudos, SonarCloud Quality Gate passed!
|
baywet
approved these changes
Feb 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes #46
Notes
Reading from a buffer drains the buffer ie, the buffer will be empty after reading all the bytes in it. The bug occured because
req.Bodywas passed tocompressReqBodyafter its contents had been read atline 69which means whatevercompressReqBodyreceived was empty.