adds support for deserialization of composed types #1603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baywet
added
the
generator
baywet
force-pushed
the
feature/union-types-serialization
branch
from
fed80d0 to
a434cc8
Compare
baywet
force-pushed
the
feature/union-types-serialization
branch
2 times, most recently
from
b435ae8 to
8a3489b
Compare
baywet
force-pushed
the
feature/union-types-serialization
branch
2 times, most recently
from
99b09fb to
2e0179a
Compare
baywet
force-pushed
the
feature/union-types-serialization
branch
from
2e0179a to
17a2660
Compare
baywet
force-pushed
the
feature/union-types-serialization
branch
2 times, most recently
from
b2a5eb3 to
1c8f8b2
Compare
This was referenced Aug 16, 2022
baywet
force-pushed
the
feature/union-types-serialization
branch
3 times, most recently
from
d2a8dae to
af2e08f
Compare
baywet
force-pushed
the
feature/union-types-serialization
branch
2 times, most recently
from
75949b0 to
81ae9ec
Compare
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
…erty and interfaces
baywet
force-pushed
the
feature/union-types-serialization
branch
from
4ce88a7 to
60a26fc
Compare
baywet
requested review from
andrueastman,
darrelmiller,
zengin,
MIchaelMainer,
ddyett,
peombwa,
nikithauc,
ramsessanchez,
calebkiage,
Ndiritu and
rkodev
as code owners
This was referenced Sep 2, 2022
andrueastman
reviewed
Sep 6, 2022
src/Kiota.Builder/OpenApiExtensions/OpenApiEnumValuesDescriptionExtension.cs
Outdated
Show resolved
Hide resolved
| if(entry.Value.AllOf != null) | ||
| foreach(var allOfEntry in entry.Value.AllOf.Where(static x => !string.IsNullOrEmpty(x.Reference?.Id))) { | ||
| var dependents = inheritanceIndex.GetOrAdd(allOfEntry.Reference.Id, new ConcurrentDictionary<string, bool>(StringComparer.OrdinalIgnoreCase)); | ||
| dependents.TryAdd(entry.Key, false); |
There was a problem hiding this comment.
Just to confirm, the reason we have dummy values is because we do not have a data structure like a ConcurrentHashSet in the .Net Api? Otherwise, there would be no need for the dummy false values. Yes?
There was a problem hiding this comment.
correct, the general recommendation is to use a concurrent dictionary instead.
|
LGTM |
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
|
Kudos, SonarCloud Quality Gate passed! |
andrueastman
approved these changes
Sep 8, 2022
This was referenced Sep 15, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1411