Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes a bug where collections types would generate invalid return types in CSharp #1733

Merged
merged 1 commit into from
Jul 12, 2022
Merged

fixes a bug where collections types would generate invalid return types in CSharp #1733

merged 1 commit into from
Jul 12, 2022

Conversation

baywet
Copy link
Member

@baywet baywet commented Jul 11, 2022

regression from #1530, no changes to our samples

@baywet baywet added type:bug A broken experience Csharp Pull requests that update .net code labels Jul 11, 2022
@baywet baywet self-assigned this Jul 11, 2022
@baywet baywet enabled auto-merge July 11, 2022 14:26
@baywet baywet mentioned this pull request Jul 11, 2022
Closed
4 tasks
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

92.1% 92.1% Coverage
0.0% 0.0% Duplication

andrueastman
andrueastman approved these changes Jul 12, 2022
View reviewed changes
Copy link
Member

@andrueastman andrueastman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@baywet baywet merged commit eea5b12 into main Jul 12, 2022
@baywet baywet deleted the bugfix/collections-types-csharp branch July 12, 2022 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrueastman andrueastman andrueastman approved these changes

@darrelmiller darrelmiller Awaiting requested review from darrelmiller

@zengin zengin Awaiting requested review from zengin

@MIchaelMainer MIchaelMainer Awaiting requested review from MIchaelMainer

@ddyett ddyett Awaiting requested review from ddyett

@peombwa peombwa Awaiting requested review from peombwa

@nikithauc nikithauc Awaiting requested review from nikithauc

@ramsessanchez ramsessanchez Awaiting requested review from ramsessanchez

@calebkiage calebkiage Awaiting requested review from calebkiage

@Ndiritu Ndiritu Awaiting requested review from Ndiritu

Assignees

@baywet baywet

Labels
Csharp Pull requests that update .net code type:bug A broken experience
Projects
None yet
Milestone
Complete Graph API Surface support
Development

Successfully merging this pull request may close these issues.
2 participants
@baywet @andrueastman