PHP: Multi-definition trimming and property defaults #1737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baywet
requested changes
Jul 13, 2022
Ndiritu
requested review from
andrueastman,
darrelmiller,
zengin,
MIchaelMainer,
ddyett,
peombwa,
nikithauc,
ramsessanchez and
calebkiage
as code owners
baywet
requested changes
Jul 13, 2022
Ndiritu
force-pushed
the
philip/php/failing-generation
branch
from
5658561 to
49a33ed
Compare
baywet
previously approved these changes
Jul 14, 2022
|
Sorry @baywet, found another minor issue when updating Kiota samples for PHP. |
|
Samples - microsoft/kiota-samples#834 |
baywet
requested changes
Jul 15, 2022
Ndiritu
force-pushed
the
philip/php/failing-generation
branch
from
64d8e9a to
678e49e
Compare
Ndiritu
force-pushed
the
philip/php/failing-generation
branch
from
678e49e to
9b067ec
Compare
|
Kudos, SonarCloud Quality Gate passed! |
baywet
approved these changes
Jul 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1724