-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multi-Value headers support for PHP Generation #2173
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this pattern increases the effort to configure headers on a request (at least for PHP)
Using the request config object, devs have an extra step to instantiate a RequestHeaders object vs using a more familiar PSR header format/pattern
For devs manipulating the request information object directly, we could add a setter instead of publicly exposing the headers property to append values to existing headers.
Kudos, SonarCloud Quality Gate passed! |
Abstraction changes
Generation changes.