Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-Value headers support for PHP Generation #2173

Merged
merged 7 commits into from
Jan 23, 2023

Conversation

SilasKenneth
Copy link
Member

@SilasKenneth SilasKenneth commented Jan 20, 2023

  • [PHP] Support for Multi-Value Headers.
  • Add changelog entry.

Abstraction changes

Generation changes.

@SilasKenneth SilasKenneth self-assigned this Jan 20, 2023
baywet
baywet previously approved these changes Jan 20, 2023
Copy link
Contributor

@Ndiritu Ndiritu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this pattern increases the effort to configure headers on a request (at least for PHP)

Using the request config object, devs have an extra step to instantiate a RequestHeaders object vs using a more familiar PSR header format/pattern

For devs manipulating the request information object directly, we could add a setter instead of publicly exposing the headers property to append values to existing headers.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@SilasKenneth SilasKenneth requested a review from Ndiritu January 23, 2023 12:11
@SilasKenneth SilasKenneth merged commit d0c64cc into main Jan 23, 2023
@SilasKenneth SilasKenneth deleted the php/multi-value-headers branch January 23, 2023 13:49
@SilasKenneth SilasKenneth linked an issue Jan 23, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PHP - add support for multi-valued headers
3 participants