-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature/backing store #223
Conversation
0138bf5
to
be3aa39
Compare
7e3f884
to
bc8f02e
Compare
55014b1
to
e5fb84f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed at a high-level with Vincent via video conference.
global nit: add copyright and class documentation before finalizing PR. The code comments would've been useful during the review.
Do need documentation for backing store features. Backing store enables a lot. Capture the scenarios this enables in the documentation.
I didn't see a link to a design document. If one publicly exists, can you share? This is good stuff.
…lization and deserilization
- adds change status update on backing store
- adds serilization writers proxies for backing store
- adds a proxy factory for the parse node
27da501
to
02bd6ab
Compare
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I appreciate this feature a lot.
fixes #81
Generation changes
microsoft/kiota-samples#85
TODO: