Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/vs code operations #2616

Merged
merged 18 commits into from
May 2, 2023
Merged

feature/vs code operations #2616

merged 18 commits into from
May 2, 2023

Conversation

baywet
Copy link
Member

@baywet baywet commented Apr 26, 2023

fixes #2556
fixes #2562

@darrelmiller
Copy link
Member

darrelmiller commented Apr 26, 2023

Filtering is not including the operation nodes

image

And if I clear the filter, then I lose the selected/focused node.

Hmmm, but sometimes it is.

image

@baywet baywet disabled auto-merge April 27, 2023 12:17
@baywet
Copy link
Member Author

baywet commented Apr 27, 2023

@darrelmiller thanks for testing things out. I'll take a closer look at operations display when filtering. It's odd the behaviour varies.
As for the selected node. I believe this is native behaviour from the VS code tree view, I'm not sure there's a workaround that. (VS Code internals handle selection, collapsed state and more)

@baywet baywet enabled auto-merge April 27, 2023 15:21
@sonarqubecloud
Copy link

sonarqubecloud bot commented May 2, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

62.9% 62.9% Coverage
0.0% 0.0% Duplication

@baywet baywet merged commit a7b7e7d into main May 2, 2023
@baywet baywet deleted the feature/vs-code-operations branch May 2, 2023 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants