-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds support for serialization of csv values for Go enums #3210
Conversation
5d44c0e
to
e9914cc
Compare
@rkodev multiple integration tests are failing, can you have a look please? |
549fa21
to
219bfd4
Compare
95c25d3
to
dd29479
Compare
dd29479
to
3ffc4ab
Compare
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@baywet I'm okay to have this merged as it fits into the general bigger picture of what we'd want to do, and I've documented the conversations/findings at #3237.
@rkodev You can probably assign the related Go SDK issues to me and then I'll close them once the issue is closed (hopefully before the next generation cycle 😅 ).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm perfectly fine with merging this one as is and have the work on the flags being implemented later. I know this won't solve the customer issue that's linked right now, but we're making progress towards it. @rkodev maybe unlink the "fixes" before you merge the PR?
Resolves microsoftgraph/msgraph-sdk-go#517
Adds support for serialization of csv values for Go enums by adding a value mask that can support multiple Go values