Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adds doc comments for CSharp/TypeScript/Java abstractions #324

Merged
merged 6 commits into from
Jul 15, 2021
Merged

adds doc comments for CSharp/TypeScript/Java abstractions #324

merged 6 commits into from
Jul 15, 2021

Conversation

baywet
Copy link
Member

@baywet baywet commented Jul 13, 2021

Summary

  • adds doc comments for all of dotnet abstractions
  • documentation typos and naming conventions fixes
  • adds doc comments for java abstractions

fixes #255

No generation diff for this one.

@baywet baywet added this to the Alpha milestone Jul 13, 2021
@baywet baywet self-assigned this Jul 13, 2021
@baywet baywet linked an issue Jul 13, 2021 that may be closed by this pull request
doc comment all abstraction classes/libraries #255
Closed
@baywet baywet marked this pull request as ready for review July 14, 2021 13:25
@baywet baywet force-pushed the feature/client-configuration branch from 3974e6f to 82d43c4 Compare July 14, 2021 13:31
@baywet baywet force-pushed the feature/abstractions-doc branch from fc84167 to 615f1e8 Compare July 14, 2021 13:34
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

MIchaelMainer
MIchaelMainer approved these changes Jul 15, 2021
View reviewed changes
Copy link
Member

@MIchaelMainer MIchaelMainer left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hallelujah, my prayers from the last PR have been mostly answered! 🙏

I still want to see examples in the comments for what a writer in a method writes to file.

Base automatically changed from feature/client-configuration to main July 15, 2021 11:15
@baywet baywet merged commit 2d53c70 into main Jul 15, 2021
@baywet baywet deleted the feature/abstractions-doc branch July 15, 2021 11:44
@baywet baywet mentioned this pull request Jul 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MIchaelMainer MIchaelMainer MIchaelMainer approved these changes

@abfarah abfarah Awaiting requested review from abfarah

@darrelmiller darrelmiller Awaiting requested review from darrelmiller

@ddyett ddyett Awaiting requested review from ddyett

@nikithauc nikithauc Awaiting requested review from nikithauc

@peombwa peombwa Awaiting requested review from peombwa

@zengin zengin Awaiting requested review from zengin

Assignees

@baywet baywet

Labels
None yet
Projects
None yet
Milestone
Alpha
Development

Successfully merging this pull request may close these issues.

doc comment all abstraction classes/libraries
2 participants
@baywet @MIchaelMainer