Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a basic MockServer integration test for Python #3567

Merged
merged 2 commits into from
Oct 24, 2023
Merged

Add a basic MockServer integration test for Python #3567

merged 2 commits into from
Oct 24, 2023

Conversation

andreaTP
Copy link
Contributor

restoring #3534

@andreaTP andreaTP requested a review from a team as a code owner October 24, 2023 15:09
baywet
baywet approved these changes Oct 24, 2023
View reviewed changes
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reopening, and sorry about the confusion

@baywet baywet enabled auto-merge October 24, 2023 15:11
@baywet baywet merged commit 919364d into microsoft:main Oct 24, 2023
@andreaTP
Copy link
Contributor Author

The test passed in CI:
https://github.com/microsoft/kiota/actions/runs/6628840229/job/18007061124?pr=3567#step:14:897

But PHP seems to be broken ...

@baywet
Copy link
Member

baywet commented Oct 24, 2023

yes, that's because we made a contribution to the upstream library to support generics but haven't implemented the changes here yet. see #3542

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baywet baywet baywet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andreaTP @baywet