Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix enum name evaluation in go contructors #3836

Merged
merged 2 commits into from
Nov 30, 2023
Merged

Fix enum name evaluation in go contructors #3836

merged 2 commits into from
Nov 30, 2023

Conversation

rkodev
Copy link
Contributor

@rkodev rkodev commented Nov 30, 2023

Fixes #3436

checks the Enum serialization name in Enum options before defaulting to the example name

@rkodev rkodev requested a review from a team as a code owner November 30, 2023 08:02
@rkodev rkodev force-pushed the fix/go/eval-enum-name-in-contructors branch from cc759e2 to 7102f22 Compare November 30, 2023 08:15
rkodev and others added 2 commits November 30, 2023 11:17
@rkodev rkodev force-pushed the fix/go/eval-enum-name-in-contructors branch from 4dccc10 to ccad609 Compare November 30, 2023 08:17
@sonarqubecloud SonarQubeCloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@rkodev rkodev merged commit 52d1977 into main Nov 30, 2023
170 of 173 checks passed
@rkodev rkodev deleted the fix/go/eval-enum-name-in-contructors branch November 30, 2023 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrueastman andrueastman andrueastman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Go '_' must separate successive digits
2 participants
@rkodev @andrueastman