Fixes generated paths folders from get too long

[andrueastman]

Fixes #3854

In summary, changes include

• Prevents the namespace folder name from getting too long
• Normalized paths if they are longer than windows MAX_PATH similar to Go

[sonarqubecloud]

Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
93.8% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[0xfeeddeadbeef]

PR description mentions MAX_PATH, which is 260

32767 is max length of an extended-length path, which requires \\?\ prefix.

This constant should be 260. I'm I mistaken?

[baywet]

Thanks for double-checking.
Let's start by defining the question precisely, which has historically been the challenge when working on path lengths:
which maximum path length should kiota generate files at?

This has two main components:

• what does the local file system support as a maximum path length?
• what will the compiler receiving those files support?

We SHOULD NOT limit the generation to an outdated requirement pushed from older OS configurations:

• windows supports 32K characters and has for a while, yes, it's still not turned on by default, but it's in some enterprises, and it's easy to do so if needed. And this without having to specify the prefix.
• linux has supported ~4k characters for a long time as well now.

We could consider 4k our upper-bound for any language out there as a safety measure, but this is something that's likely to change in the future, also this is something user can change either by configuration or by targeting a shorter path.

As for the compiler receiving those files, there are situations where in order to be packaged, the file path relative to the package directory cannot exceed a specific length (npm, ruby...) , or the compiler will impose limitations (go), in which case to maintain compatibility with the ecosystem being targeted, we should (and have) implement file path length limits when possible.

I hope this addresses your concern?

[0xfeeddeadbeef]

Makes sense. Thanks!