Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

- projects required query parameters as required in the template #4087

Merged
merged 2 commits into from
Jan 31, 2024
Merged

- projects required query parameters as required in the template #4087

merged 2 commits into from
Jan 31, 2024

Conversation

baywet
Copy link
Member

@baywet baywet commented Jan 30, 2024

fixes #3989

@baywet baywet requested a review from a team as a code owner January 30, 2024 20:09
@baywet baywet self-assigned this Jan 30, 2024
@baywet baywet enabled auto-merge January 30, 2024 20:09
andrueastman
andrueastman previously approved these changes Jan 31, 2024
View reviewed changes
andrueastman
andrueastman reviewed Jan 31, 2024
View reviewed changes
Copy link
Member

@andrueastman andrueastman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @baywet.

There is however a failing test due to the updating ordering of the parameters at

kiota/tests/Kiota.Builder.Tests/Extensions/OpenApiUrlTreeNodeExtensionsTests.cs

Line 250 in 801c779

Assert.Equal("{+baseurl}/{param%2Dwith%2Ddashes}/existing-segment{?%24select,api%2Dversion,api%7Etopic,api%2Eencoding}", node.Children.First().Value.GetUrlTemplate());

baywet added 2 commits January 31, 2024 10:01
@baywet
- projects required query parameters as required in the template
1e61c90 
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
- fixes failing unit test
d6291f9 
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet baywet force-pushed the bugfix/required-query-parameters branch from 7026cc2 to d6291f9 Compare January 31, 2024 15:08
@baywet
Copy link
Member Author

baywet commented Jan 31, 2024

Thanks for the call out, for some reason dotnet test seems to get stuck on my new devbox...

@baywet baywet requested a review from andrueastman January 31, 2024 15:09
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@baywet baywet merged commit 4ed90ca into main Jan 31, 2024
185 of 186 checks passed
@baywet baywet deleted the bugfix/required-query-parameters branch January 31, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrueastman andrueastman andrueastman approved these changes

Assignees

@baywet baywet

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change how required parameters are represented in URI Templates
2 participants
@baywet @andrueastman