-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sanitize string headers when writing request generator #4218
Conversation
@crobibero please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
@microsoft-github-policy-service agree |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contributions!
Can you please:
- Add an entry to the changelog (unreleased, changed)
- Add a unit test (code method writer tests, CSharp)
While I understand your main concern was about CSharp, this is most likely a concern that applies to other languages as well. Would you be willing to fix it for the other languages?
I've updated all generators but typescript and cli since I wasn't able to figure out how to test them, any tips for those are appreciated |
f5905a4
to
5710263
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making the changes! Taking this opportunity to normalize to single quotes in Ruby since we're not doing any string interpolation with those values.
tests/Kiota.Builder.Tests/Writers/Ruby/CodeMethodWriterTests.cs
Outdated
Show resolved
Hide resolved
Pull Request is not mergeable
Pull Request is not mergeable
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
Fixes #4211